angarg12 /
nucleogenesis
| Conditions | 1 |
| Paths | 4 |
| Total Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 5 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | /* globals Ziggurat */ |
||
| 17 | function(prettyNumber, $sce, data, state) { |
||
| 18 | this.gaussian = new Ziggurat(); |
||
| 19 | |||
| 20 | /* Return the HTML representation of an element, or the element itself |
||
| 21 | if it doesn't have one */ |
||
| 22 | this.getHTML = function(resource) { |
||
| 23 | let html = data.html[resource]; |
||
| 24 | if (typeof html === 'undefined' && data.resources[resource]) { |
||
| 25 | html = data.resources[resource].html; |
||
| 26 | } |
||
| 27 | if (typeof html === 'undefined') { |
||
| 28 | return resource; |
||
| 29 | } |
||
| 30 | return html; |
||
| 31 | }; |
||
| 32 | |||
| 33 | this.prettifyNumber = function(number) { |
||
| 34 | if (typeof number === 'undefined' || number === null) { |
||
| 35 | return null; |
||
| 36 | } |
||
| 37 | if (number === '') { |
||
| 38 | return ''; |
||
| 39 | } |
||
| 40 | if (number === Infinity) { |
||
| 41 | return '∞'; |
||
| 42 | } |
||
| 43 | if (number === 0) { |
||
| 44 | return '0'; |
||
| 45 | } |
||
| 46 | return numberformat.format(number, state.player.numberformat); |
||
| 47 | }; |
||
| 48 | |||
| 49 | this.randomDraw = function(number, p) { |
||
| 50 | let production; |
||
| 51 | let mean = number * p; |
||
| 52 | // Gaussian distribution |
||
| 53 | let q = 1 - p; |
||
| 54 | let variance = number * p * q; |
||
| 55 | let std = Math.sqrt(variance); |
||
| 56 | production = Math.round(this.gaussian.nextGaussian() * std + mean); |
||
| 57 | if (production > number) { |
||
| 58 | production = number; |
||
| 59 | } |
||
| 60 | if (production < 0) { |
||
| 61 | production = 0; |
||
| 62 | } |
||
| 63 | return production; |
||
| 64 | }; |
||
| 65 | |||
| 66 | this.trustHTML = function(html) { |
||
| 67 | return $sce.trustAsHtml(html); |
||
| 68 | }; |
||
| 69 | } |
||
| 70 | ]); |
||
| 71 |
